PHPORM-255 Enable disabling the id to _id field rename in embedded documents
#3332
Conversation
| @@ -123,6 +125,8 @@ class Builder extends BaseBuilder | |||
| */ | |||
| public $options = []; | |||
|
|
|||
| private ?bool $renameEmbeddedIdField; | |||
There was a problem hiding this comment.
If this property is only set on the connection, should it be defined here on the builder?
There was a problem hiding this comment.
There are builder instances created in many places, you don't always have access to them to change the setting on each specific instance.
If we used a static variable, it would apply to every connection.
So I think that the connection is the good level for this setting.
There was a problem hiding this comment.
I agree, which is why I'm confused that this property is also defined here on the builder. I guess I meant, "this shouldn't be defined here on the builder, because it's never set on the builder".
There was a problem hiding this comment.
Oh, right. I forgot to remove it after trying to define it in the builder. Which did not work well.
| { | ||
| if (array_key_exists('id', $values)) { | ||
| if (array_key_exists('id', $values) && ($root || $this->connection->getRenameEmbeddedIdField())) { |
There was a problem hiding this comment.
would it be easier to check:
if (!$root && !$this->connection->getRenameEmbeddedIdField()) return $values; at the beginning instead of checking them multiple times in the function?
Fix PHPORM-255
Fix #3184
To disable the automatic conversion of
idto_idand storeidfields in the database for embedded documents, set the connection setting using the new method:Checklist