DRIVERS-3131: Provide AWS scripts with no URI credentials #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
force-pushed
the
DRIVERS-3131
branch
8 times, most recently
from
2c03b7a to
98ed825
Compare
durran
force-pushed
the
DRIVERS-3131
branch
from
98ed825 to
7c7ee0c
Compare
|
You could instead add a cli option to the existing file to avoid writing the creds into the URI. |
|
Testing PyMongo against this branch: https://spruce.mongodb.com/version/68dbe91f99660700071825ad/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a --nouri option to aws_tester.py to prevent credentials from being put in the MONGODB_URI. Adds tests.
Node run: https://spruce.mongodb.com/version/68dbea54eb794e0007f7a2fe/tasks?page=0&sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC&variant=%5Eubuntu2004-test-mongodb-aws%24