feat(NODE-6727): Add builds on Alpine linux #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
alpine
branch
3 times, most recently
from
20fc317 to
7d8ba81
Compare
baileympearson
changed the title
baileympearson
force-pushed
the
alpine
branch
from
7d8ba81 to
93360b7
Compare
baileympearson
commented
Feb 6, 2025
| @@ -0,0 +1,46 @@ | |||
| #! /bin/bash | |||
|
|
|||
| # script to aid in local testing of linux platforms | |||
There was a problem hiding this comment.
I'm happy to remove this, but I find this immensely useful when working on ubuntu or alpine builds locally. We have this script in our zstd repo.
durran
added
the
Primary Review
durran
approved these changes
Feb 7, 2025
nbbeeken
requested changes
Feb 7, 2025
nbbeeken
added
Team Review
nbbeeken
requested changes
Feb 7, 2025
nbbeeken
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This PR adds alpine builds to CI.
I don't know of a way to test our prebuilds with an actual release outside of releasing an alpha (to use the actual release workflow), so for now, we should double check that the tooling matches the .glibc version and we can release an alpha if we want to once this PR is merged.
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript