Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-6727): Add builds on Alpine linux #65

Merged
merged 5 commits into from
Feb 10, 2025

Conversation

baileympearson
Copy link
Collaborator

@baileympearson baileympearson commented Feb 5, 2025

Description

What is changing?

This PR adds alpine builds to CI.

I don't know of a way to test our prebuilds with an actual release outside of releasing an alpha (to use the actual release workflow), so for now, we should double check that the tooling matches the .glibc version and we can release an alpha if we want to once this PR is merged.

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson force-pushed the alpine branch 3 times, most recently from 20fc317 to 7d8ba81 Compare February 6, 2025 19:10
@baileympearson baileympearson changed the title draft - alpine feat(NODE-6727): Add builds on Alpine linux Feb 6, 2025
@@ -0,0 +1,46 @@
#! /bin/bash

# script to aid in local testing of linux platforms
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to remove this, but I find this immensely useful when working on ubuntu or alpine builds locally. We have this script in our zstd repo.

@durran durran self-assigned this Feb 6, 2025
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 6, 2025
@baileympearson baileympearson marked this pull request as ready for review February 6, 2025 23:38
@baileympearson baileympearson requested a review from a team as a code owner February 6, 2025 23:38
@nbbeeken nbbeeken self-requested a review February 7, 2025 16:50
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 7, 2025
@durran durran merged commit f4274d7 into mongodb-js:main Feb 10, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants