feat(compass-data-modeling): add info banner COMPASS-9773 #7345
+156
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds an informational banner that displays when a new diagram is created, explaining that the diagram is based on a sample of documents and won't affect actual data. The banner appears only for newly created diagrams and can be dismissed by the user.
- Adds
isNewlyCreatedflag to track when a diagram is newly generated - Implements dismissible info banner with data safety message
- Updates component props to include database name and newly created status
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/compass-data-modeling/src/store/diagram.ts | Adds isNewlyCreated boolean flag to diagram state and sets appropriate values during diagram operations |
| packages/compass-data-modeling/src/components/diagram-editor.tsx | Implements the info banner component with dismissible functionality and connects it to diagram state |
| packages/compass-data-modeling/src/components/diagram-editor.spec.tsx | Adds comprehensive tests for both existing and new diagram scenarios, including banner visibility and dismissal behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
cc @bsradcliffe |
paula-stacho
added
the
feature flagged
paula-stacho
force-pushed
the
COMPASS-9773
branch
from
1f02990 to
1d752a6
Compare
| className={dataInfoBannerStyles} | ||
| data-testid="data-info-banner" | ||
| > | ||
| <h4>Worried about your data?</h4> |
There was a problem hiding this comment.
Nit
- Based on Julia's comment [here], can we shorten the second sentence (https://www.figma.com/design/w51HGIb2PDdyZqyCOMMypr?node-id=1528-22764#1404509115) "Changes made to the diagram will not impact your data"
- "worried" is making me worried :) How do you feel about rephrasing as "Questions about your data?"
johnjackweir
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Info banner shows only the first time (when the diagram is newly created) and can be closed.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes