chore(monorepo): bump required Node.js version to match electron environment #7339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigned |
gribnoysup
added
the
no-title-validation
|
Seems like this minor bump reveals an issue somewhere in our units: Moving to draft for now to take a closer look |
addaleax
approved these changes
Sep 18, 2025
There was a problem hiding this comment.
@gribnoysup I'd actually check whether this also appears with the latest Node.js 22.x version, this sounds like a familiar bug in Node.js's ESM compatibility that has actually been fixed in more recent versions
|
Oh, interesting! I'll check, thanks for the pointer! |
nbbeeken
reviewed
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last time we were doing major electron upgrade, we forgot to bump required node version to match. This is just a minor one this time, so not that big of a deal, but it's helpful to keep it in sync to make sure that the tests are running in the same env that the app is running