Smnzhu/save tab #7253
Draft
Smnzhu/save tab #7253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
reviewed
Sep 17, 2025
| /** | ||
| * UserData instance to use for persisting workspace state | ||
| */ | ||
| userData: IUserData<typeof WorkspacesStateSchema>; |
There was a problem hiding this comment.
Services shouldn't be used and passed around in views like that. This should be facilicated through the store
| ); | ||
|
|
||
| useEffect(() => { | ||
| savedWorkspacesPromiseRef.current.then( |
There was a problem hiding this comment.
This shouldn't be happening in render method, this logic belongs in the store
| initialWorkspaceTabs, | ||
| }: { initialWorkspaceTabs?: OpenWorkspaceOptions[] | null }, | ||
| }: { | ||
| userData: IUserData<typeof WorkspacesStateSchema>; |
There was a problem hiding this comment.
Services should be injected through service injection mechanism, not passed as props
There was a problem hiding this comment.
Can you elaborate on this one? What's service injection mechanism?
| // Save to UserData with a fixed ID | ||
| await userData.write('current-workspace', stateToSave); | ||
|
|
||
| // Optional: Log for debugging in development |
There was a problem hiding this comment.
You should use logger service instead, we don't use console for logging (hence the eslint rule that disables it)
syn-zhu
commented
Sep 17, 2025
| return this.cloudEndpoint(path); | ||
| } | ||
| userDataEndpoint(path?: string): string { | ||
| return `https://cluster-connection.cloud-dev.mongodb.com/userData${normalizePath( |
There was a problem hiding this comment.
TODO: unhardcode this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screen.Recording.2025-09-17.at.11.48.12.AM.mov
TODO:
test ases:
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes