feat(connect): end-of-life server COMPASS-9083#6805
Closed
alenakhineika wants to merge 1 commit intomainfrom
Closed
feat(connect): end-of-life server COMPASS-9083#6805alenakhineika wants to merge 1 commit intomainfrom
alenakhineika wants to merge 1 commit intomainfrom
Conversation
12 tasks
kraenhansen
force-pushed
the
COMPASS-9083-eol-server
branch
from
3e71bad to
f5fffe5
Compare
Contributor
|
I rebased and force-pushed the branch to get a clear diff on GitHub. |
kraenhansen
reviewed
May 2, 2025
Comment on lines
+1462
to
+1469
| if (!serverVersion) { | ||
| return true; | ||
| } | ||
| try { | ||
| return semver.satisfies(serverVersion, `<=${getEoLServerVersion()}`); | ||
| } catch (e) { | ||
| return true; | ||
| } |
Contributor
There was a problem hiding this comment.
I think this should default to false in case of a missing version or failure.
kraenhansen
reviewed
May 2, 2025
Comment on lines
+1815
to
+1821
| } else if (isEndOfLifeServer(build.version)) { | ||
| dispatch( | ||
| showEndOfLifeWarningModal({ | ||
| connectionId: connectionInfo.id, | ||
| serverVersion: build.version, | ||
| }) | ||
| ); |
Contributor
There was a problem hiding this comment.
I like that this is mutually exclusive with the "non genuine modal".
Contributor
|
Closing as this was implemented in #6888 - thanks for the initial draft 💙 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Display notice when connected to an “end-of-life” server.
Checklist
Motivation and Context
Types of changes