feat(deps): bump mongosh, driver to latest COMPASS-9056 #6774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes adjusting the CSFLE/QE collection tracker for the Node.js driver changes related to `$lookup` support, where filters for listCollections can now list multiple collections in an `$in` clause.
nirinchev
approved these changes
Mar 5, 2025
| `[Compass] Unexpected listCollections request on '${dbName}' with name: '${ | ||
| filter?.name as string | ||
| }'` | ||
| `[Compass] Unexpected listCollections request on '${dbName}' with filter: ${EJSON.stringify( |
There was a problem hiding this comment.
[nit] Should we include the shape of the filter that we expect? I find it a much nicer DX when I get an error that not only tells me that I did something wrong, but also helps me do the right thing
There was a problem hiding this comment.
We could, but honestly I don't think that would be worth it, if this actually gets thrown at some point, that means we're going to have to do some digging into the root cause anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes adjusting the CSFLE/QE collection tracker for the Node.js driver changes related to
$lookupsupport, where filters for listCollections can now list multiple collections in an$inclause.Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes