feat(schema-validation): add confirmation modal when applying rules, add explicit editing state COMPASS-8861 #6766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add explicit editing state
|
I'm seeing a different copy + option to not show the modal again in the designs, are we looking at the same version?
|
|
@paula-stacho I just with Misba on the designs. We might use this wording in the pr instead of whats in the designs to be more inline with other confirmation modals in Compass (save aggregation for instance). I did miss that option not to show the modal again though thanks! I'll push up a commit today. |
…variant, enable apply on non-syntax error
|
@paula-stacho I created a new ticket for the "don't show this message again" checkbox: https://jira.mongodb.org/browse/COMPASS-9076 |
paula-stacho
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is most of COMPASS-8861, I'd like to do the toasts separately as they can be in a separate pr from this work without any conflicts.
Designs: https://www.figma.com/design/CBHJriBQZ2qxMxtnXFgDxJ/EXPO-3174-%3A-Export-Schema-%2B-Validation-Detection?node-id=1309-40813&t=ouDByoHIQallPTXr-1
Screenshots
We could refactor the store here to have fewer reducers to simplify some of the actions here. Probably not worth making part of this work, but something that is on the mind with these changes. Removing some of the debouncing and cleaning up the fetching of existing validation would be nice as well.