Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(smoke-test): fail early and propagate task url #6752

Merged
merged 4 commits into from
Feb 28, 2025
Merged

chore(smoke-test): fail early and propagate task url #6752

merged 4 commits into from
Feb 28, 2025

Conversation

kraenhansen
Copy link
Contributor

@kraenhansen kraenhansen commented Feb 26, 2025 •
edited
Loading

Description

Merging this PR will:

  • Refactor dispatch function to poll for completion and return a status, which can be asserted from the caller.
  • ☝️ makes the dispatch command fail earlier (before it would wait for successful completion), allowing someone to manually restart the GHA run.
  • Stop printing the help message when the smoke test CLI fails (because it's annoying to have to scroll past on CI).
  • Propagate the Evergreen task URL into the GHA job summary, to make increase traceability between the two systems.

Screenshot 2025-02-28 at 10 44 42

@kraenhansen kraenhansen added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Feb 26, 2025
@kraenhansen kraenhansen self-assigned this Feb 26, 2025
@kraenhansen kraenhansen requested a review from lerouxb February 26, 2025 10:08
@kraenhansen kraenhansen force-pushed the kh/smoke-test/fail-early-and-propagate-task-url branch from 979453f to 94a8074 Compare February 26, 2025 12:34
lerouxb
lerouxb reviewed Feb 26, 2025
View reviewed changes
packages/compass-smoke-tests/src/cli.ts
@@ -71,6 +71,7 @@ yargs(hideBin(process.argv))
.scriptName('smoke-tests')
.detectLocale(false)
.version(false)
.showHelpOnFail(false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@kraenhansen kraenhansen merged commit c74e1ce into main Feb 28, 2025
54 checks passed
@kraenhansen kraenhansen deleted the kh/smoke-test/fail-early-and-propagate-task-url branch February 28, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lerouxb lerouxb lerouxb approved these changes

Assignees

@kraenhansen kraenhansen

Labels
no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kraenhansen @lerouxb