feat(connection-form): add connection and anonymous id to app name for atlas connections COMPASS-8591 #6750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
changed the title
gagik
force-pushed
the
gagik/add-connection-and-telemetry-info
branch
from
10778a0 to
b23fceb
Compare
gagik
commented
Feb 27, 2025
| await waitFor(() => { | ||
| screen.getByText('Connected to localhost:27017'); | ||
| }); | ||
|
|
||
| expect(onTrackSpy).to.have.been.calledWith('New Connection'); | ||
|
|
||
| const connectionId = onTrackSpy.firstCall.args[1][ |
There was a problem hiding this comment.
a bit weird to get it from there though has added benefit of making sure tracking + the URL are consistent.
gagik
commented
Feb 27, 2025
| @@ -14,7 +20,11 @@ export function setAppNameParamIfMissing( | |||
| const searchParams = | |||
| connectionStringUrl.typedSearchParams<MongoClientOptions>(); | |||
| if (!searchParams.has('appName') && defaultAppName !== undefined) { | |||
| searchParams.set('appName', defaultAppName); | |||
| const appName = `${defaultAppName}${ | |||
There was a problem hiding this comment.
I used - as a separator, open to suggestions if this can be problem causing in ways
gagik
commented
Feb 27, 2025
gagik
force-pushed
the
gagik/add-connection-and-telemetry-info
branch
from
843f0eb to
0d21b46
Compare
gagik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See COMPASS-8591