-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(compass-shell): update mongosh logging #6748
Conversation
fc88ad4
to
b5afe21
Compare
81ae462
to
6430723
Compare
package-lock.json
Outdated
"peerDependencies": { | ||
"bson": "6.x" | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know npm can be quite annoying when it comes to bumping shell dependencies (last time I did have to manually adjust the package-lock file 😕 ), but I think we'd want to keep mongodb-log-writer
and the @mongosh/...
packages hoisted to the top, if we can
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing would have applied in #6747, btw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having mongodb-log-writer
as a dependency at root would force that hoisting right? i.e. a96251d
(#6748)
I know we don't do this at all right now in compass but seems weird for the fix to be something so manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, so, ideally the way updating dependencies would work is that you add them as root dependencies, run npm install
and then remove them again as root dependencies, because npm
should keep them pre-hoisted
I don't know why that doesn't properly work right now, though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, did that now 👍 but why do we not keep them as root dependencies just to make the hoisting explicit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if we want to fix the package-lock.json in a follow-up
70fd210
to
d67cc5b
Compare
25f672b
to
4405b6b
Compare
Since this is breaking CI and needs some more adjustments across the code-base, going to separate the |
Updates and applies the breaking changes from
@mongosh/logging
.