chore(schema): add tooltip showing folks the export button when they legacy export schema COMPASS-8971 #6744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…legacy export schema
packages/compass-schema/src/components/export-schema-legacy-modal.tsx
Outdated
Show resolved
Hide resolved
|
Thank you! No tests needed. Just one thing - if it's not too complicated, it would be nice to show also if they switch to and complete the new export. Since they came in the legacy way, it might be they haven't noticed the button. |
Anemy
commented
Feb 26, 2025
| @@ -238,7 +238,9 @@ export const changeExportSchemaFormat = ( | |||
| try { | |||
| const schemaAccessor = schemaAccessorRef.current; | |||
| if (!schemaAccessor) { | |||
| throw new Error('No schema analysis available'); | |||
| throw new Error( | |||
| "No schema analysis available. Please analyze the collection's schema before exporting." | |||
There was a problem hiding this comment.
Drive-by, updated this error message to be a bit more descriptive as folks do see it if they try exporting and they have not yet run analysis.
|
@paula-stacho Pushed a commit to show the tooltip after the new export modal has closed after using the legacy menu entry. Looks like there was an simple way to do it after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-8971
This'll go away eventually. Didn't add any tests, I can if folks would like.
Drive by renamed the
bannertomodalas it is a modal.