Add CoinMarketCap cryptocurrencies source #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start implementing #5
@frederikbosch please have a look at the output files. There are more cryptocurrencies that start with a number and have more than one leading number in their symbol. Some contain only numbers. What are your thoughts?
In addition, we will need to decide what to do with Binance source. CoinMarketCap contains all cryptocurrencies, I would be surprized if it did not include all cryptocurrencies from Binance already. I suggest to keep both sources though, but there is no need to merge them.
As we go along, we can add more crypto exchanges as sources and then we may need to merge the output from all crypro exchanges.