Skip to content

refactor: exit after installation failure #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xxxxxliil wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: exit after installation failure #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions rootfs/usr/local/bin/startup
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,14 @@ else
-e "s|<FLARUM_TITLE>|${FLARUM_TITLE}|g" /flarum/app/config.yml

# Install flarum
su-exec "${UID}:${GID}" php /flarum/app/flarum install --file=/flarum/app/config.yml \
&& touch /flarum/app/public/assets/._flarum-installed.lock

echo "[INFO] End of flarum installation"
if su-exec "${UID}:${GID}" php /flarum/app/flarum install --file=/flarum/app/config.yml; then
touch /flarum/app/public/assets/._flarum-installed.lock
echo "[INFO] End of flarum installation"
else
echo "[ERROR] The flarum installation fails, Now exit!"
exit 75
Copy link
Member

@al3xLvs al3xLvs Jun 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you use code 75?
I think this change is unnecessary.

Copy link
Contributor Author

@xxxxxliil xxxxxliil Jun 10, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you use code 75?
I think this change is unnecessary.

defined in /usr/include/sysexits.h

 *      EX_TEMPFAIL -- temporary failure, indicating something that
 *              is not really an error.  In sendmail, this means
 *              that a mailer (e.g.) could not create a connection,
 *              and the request should be reattempted later.
...
#define EX_TEMPFAIL     75      /* temp failure; user is invited to retry */

fi
fi

echo "[INFO] End of startup script. Forum is starting."
echo "[INFO] End of startup script. Forum is starting..."
exec su-exec "${UID}:${GID}" /bin/s6-svscan /etc/s6.d