Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Windows Git Bash #99

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Conversation

amenocal
Copy link
Contributor

This pull request primarily refactors the gh-repo-stats file to improve the GitHub API calls and adds a new condition to handle Windows operating systems. The changes include modifying the API endpoint calls, and adding a condition to handle leading slashes in Windows operating systems.

related issue cli/cli#6415

Warning

When running this in a windows-latest I kept getting base64: invalid. However, the .csv output file contained accurate info on repos I checked

Log

Analyzing Repo: actions-demo
base64: invalid input
base64: invalid input
base64: invalid input
base64: invalid input
base64: invalid input

marking my branch

remove leading slash and escaping slash

debugging where base 64 is going wrong

attempt to remove newline characters

typo
@amenocal amenocal requested a review from a team as a code owner March 29, 2024 20:59
gh-repo-stats Fixed Show fixed Hide fixed
gh-repo-stats Fixed Show fixed Hide fixed
gh-repo-stats Fixed Show fixed Hide fixed
gh-repo-stats Fixed Show fixed Hide fixed
gh-repo-stats Fixed Show fixed Hide fixed
gh-repo-stats Fixed Show fixed Hide fixed
@amenocal amenocal marked this pull request as draft March 29, 2024 21:06
@amenocal amenocal force-pushed the amenocal/windows-compatibility branch from 3d789d5 to 1bda8a5 Compare March 29, 2024 21:07
@amenocal amenocal marked this pull request as ready for review March 29, 2024 21:10
Copy link
Contributor

@ssulei7 ssulei7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for your contributions @amenocal

@amenocal amenocal merged commit 6de098d into main Apr 1, 2024
10 checks passed
@amenocal amenocal deleted the amenocal/windows-compatibility branch April 1, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants