Skip to content

Conversation

@alee5646
Copy link
Contributor

@alee5646 alee5646 commented Jan 5, 2026

Summary

Files updated:

Reason for change: What was the problem?

Changes made:

- lookup needed to be changed from - to | between quarters 

Checks for creator

Delete all non-relevant lines below, and then tick off as completed:

  • [ x] I have run the code in the scripts I have changed
  • [ x] I have run the relevant run_data/run_tables file
  • [ x] I have included comments to explain my code
  • [ x] I have checked the layout of the code is logical and easy to follow
  • [ x] I have checked new variables are named consistently

Closing issues

Replace the XXX with the issue numbers for any issues that can now be closed:

Close #XXX

Checks for reviewer

Creator - delete any not relevant. Reviewer - tick as completed:

  • I have run the code in the scripts that have changed
  • I have run the relevant run_data/run_tables file
  • I have checked the layout of the code is logical and easy to follow
  • I have checked new variables are named consistently
  • I have checked the list of github issues

@alee5646
Copy link
Contributor Author

alee5646 commented Jan 8, 2026

@JamC98 Hi Jamie, would you mind reviewing this PR, its for changing the table 10 lookup to use | instead of - in the quarters

Copy link
Contributor

@JamC98 JamC98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timeliness CSV uses "-" rather than "|" for the quarter column unlike the lookup so the regional timeliness tables (fr_timeliness_rep_ew and fr_timeliness_rep_region) need to be updated to account for this now that year_quarter has been changed in fr_timeliness_with_rep table.

Alternatively you can remove the replace in fr_timeliness_with_rep and modify the lookup tables directly to have "|" instead

@alee5646
Copy link
Contributor Author

Apologies I didn't catch that, altered the fr_timeliness_rep_ew and fr_timeliness_rep_regio to account for the change to |

@JamC98
Copy link
Contributor

JamC98 commented Jan 16, 2026

There was an issue with the drop table statement, the annual lookup had the full year in and the quarterly lookup had an extra "|". I've changed them myself since it was quick to do. If you're happy then you can merge in @alee5646

@alee5646
Copy link
Contributor Author

Thanks for catching that Jamie, happy to merge

@alee5646 alee5646 merged commit f414ffc into development Jan 16, 2026
@alee5646 alee5646 deleted the fr_tbl10_tweaks branch January 16, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants