pin xstatic packages to legacy versions #1906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added some upper version limit for all xstatic* packages, so it uses the proven legacy versions. The upper limit should be removed again after xstatic 2.0.0 is released and after all xstatic-* used by moin were modernized, released and tested with moin. Then the limits shall be adjusted so that the modernized version is the minimum requirement (to avoid any mixup of legacy and modernized packages).
|
Shouldn't we also raise some minimum versions if they are more than 2 or 3 years old? |
|
@UlrichB22 There is no need to do that now. After all modernized packages are available/released, it will need an update to these versions as minimum version anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some upper version limit for all xstatic* packages, so it uses the proven legacy versions.
The upper limit should be removed again after xstatic 2.0.0 is released and after all xstatic-* used by moin were modernized, released and tested with moin. Then the limits shall be adjusted so that the modernized version is the minimum requirement (to avoid any mixup of legacy and modernized packages).