Fix History Page Crash (Issue #1886) #1902
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| css = "editor homepage interwiki" | ||
| uri = url_for_item(name, wiki_name=homewiki, _external=external, namespace=NAMESPACE_USERS) | ||
| except Exception: | ||
| # Fall back to default values if user profile loading fails |
There was a problem hiding this comment.
Please log the exception. This should not get unnoticed.
Also think about catching a more specific exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the history page crash for malformed user profiles and add a test
user.User(userid)logic inget_editor_infowith a try-except block to prevent crashes when encountering broken or malformed user profile metadata.test_get_editor_info.pyto verify behavior with both valid and invalid metadata.Fixes #1886