Do not go too deep in Git history #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
This PR introduces Git history depth limiting to optimize performance, with a new max_git_depth configuration parameter defaulting to 100 commits.
Key changes:
- Added new
.github/workflows/bench.ymlwith dedicated stress testing and benchmarking jobs across platforms - Modified
get_recent_commit_times_git2insrc/priority.rsto limit Git history traversal usingrevwalk.take(max_commits) - Removed benchmarking from CI workflow and created separate benchmark workflow for better organization
- Missing validation in
config.rsfor ensuringmax_git_depthis a positive number with reasonable upper bounds - Type conversion between
usizeandi32formax_git_depthcould benefit from explicit bounds checking
6 file(s) reviewed, 8 comment(s)
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
- Move build steps to a dedicated composite action - Rename bench.yml to perf.yml for clarity - Add proper Windows support with PowerShell - Improve cross-platform path handling - Separate packaging steps for better control
- Install musl-tools and musl-dev for musl targets - Add gcc-aarch64-linux-gnu for aarch64 targets - Set appropriate CC environment variable for musl builds - Separate Linux GNU and MUSL build steps
mohsen1
changed the title
- Add binutils-aarch64-linux-gnu for proper linking - Add dynamic linker symlink for aarch64 - Set correct linker and build flags for aarch64-musl
- Replace GNU toolchain with MUSL cross-compiler - Build OpenSSL statically with MUSL toolchain - Configure pkg-config for cross-compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.