ci: bring new changes from tokenizer work to main (ai loop) #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
This PR enhances the AI loop workflow with improved error handling and automation features, while simplifying the test output handling and logging mechanisms.
- Added
peter-evans/create-pull-requestaction in.github/workflows/ailoop.yamlfor automated PR creation on failures - Implemented PAT token authentication in
.github/workflows/ailoop.yamlfor enhanced GitHub API access - Added
cargo fmtandcargo clippy --fixcommands inscripts/ai-loop.shfor automatic code formatting - Simplified test output handling with
last_attempt.txtinscripts/ai-loop.shfor more focused debugging - Added
continue-on-errorflag in.github/workflows/ailoop.yamlfor graceful failure handling
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+92
to
+94
| GH_TOKEN: ${{ secrets.PAT_TOKEN }} | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| token: ${{ env.GH_TOKEN }} |
Contributor
There was a problem hiding this comment.
style: Using both GH_TOKEN and token with the same PAT value is redundant. One environment variable is sufficient.
| echo "--- End askds Output ---" >>attempts.txt | ||
| # Cleanup temp files | ||
| rm askds_input.tmp | ||
| rm last_attempt.txt |
Contributor
There was a problem hiding this comment.
logic: rm last_attempt.txt will fail if file doesn't exist - should use rm -f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.