Skip to content

Conversation

@mohsen1
Copy link
Owner

@mohsen1 mohsen1 commented Oct 17, 2025

Changelog update for issue #193 fix and version bump.

@mohsen1 mohsen1 added this pull request to the merge queue Oct 17, 2025
Merged via the queue into main with commit 0e1709a Oct 17, 2025
12 of 13 checks passed
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

This PR bumps the version from 0.25.0 to 0.25.2 and updates the CHANGELOG with historical entries, but it has a critical issue: the CHANGELOG is missing a v0.25.2 section.

Key findings:

  • Version correctly bumped to 0.25.2 in both Cargo.toml and Cargo.lock
  • CHANGELOG has 609 additions (massive changelog restoration from GitHub release data)
  • PR description claims "Changelog update for issue #193 fix", but:
    • The fix for issue #193 (-t/--tree-header & --tree-only not working in yek.yaml) was actually included in v0.24.0 (commit 891361a on Sep 23, 2025)
    • The fix is NOT documented in the v0.24.0 changelog section
    • There is NO v0.25.2 section in the CHANGELOG at all - it jumps from v0.25.0 directly to v0.24.0

The PR appears to be a release commit that restores comprehensive changelog history, but fails to document what's new in v0.25.2 itself.

Confidence Score: 1/5

  • This PR cannot be merged as-is due to missing v0.25.2 changelog entry
  • Score of 1 reflects a critical documentation issue: the CHANGELOG is missing the v0.25.2 section despite this being a v0.25.2 release. While the version bumps are correct, users need to know what changed in this version. The PR description mentions issue #193, but that fix was already in v0.24.0 and isn't even documented there. A v0.25.2 section must be added before this release can be published.
  • CHANGELOG.md requires immediate attention - must add v0.25.2 section

Important Files Changed

File Analysis

Filename Score Overview
CHANGELOG.md 1/5 Missing v0.25.2 section despite PR claiming to document issue #193 fix
Cargo.toml 5/5 Version correctly bumped from 0.25.0 to 0.25.2
Cargo.lock 5/5 Lockfile correctly updated to match new version 0.25.2

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Git as Git Repository
    participant CI as CI/CD Pipeline
    participant Release as Release System
    
    Dev->>Git: Push release commit 8d07c77
    Note over Git: Commit includes:<br/>- Version bump to 0.25.2<br/>- CHANGELOG.md update (609 additions)
    Git->>CI: Trigger release workflow
    CI->>Release: Create v0.25.2 release
    Note over Release: Issue #193 fix was<br/>already in v0.24.0<br/>(commit 891361a)
    Release-->>Dev: Release published
    Note over Dev: CHANGELOG missing<br/>v0.25.2 entry!
Loading

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment on lines 8 to +12
## [0.25.0] - 2025-09-25
[0.25.0]: https://github.com/bodo-run/yek/compare/v0.24.0...v0.25.0
### Release

- V0.25.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing v0.25.2 changelog entry. The PR description mentions "Changelog update for issue #193 fix" but there's no v0.25.2 section in the CHANGELOG. The file jumps from v0.25.0 directly to v0.24.0. Add a v0.25.2 section documenting the fix for issue #193 (-t/--tree-header & --tree-only not working in yek.yaml file).

Prompt To Fix With AI
This is a comment left during a code review.
Path: CHANGELOG.md
Line: 8:12

Comment:
**logic:** Missing v0.25.2 changelog entry. The PR description mentions "Changelog update for issue #193 fix" but there's no v0.25.2 section in the CHANGELOG. The file jumps from v0.25.0 directly to v0.24.0. Add a v0.25.2 section documenting the fix for issue #193 (`-t`/`--tree-header` & `--tree-only` not working in `yek.yaml` file).

How can I resolve this? If you propose a fix, please make it concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants