Skip to content

Commit

Permalink
Tools and Automation bug fix hour for the June 2024 cycle (#51712)
Browse files Browse the repository at this point in the history
  • Loading branch information
SiaraMist authored Jul 23, 2024
1 parent b0fc89e commit bd77646
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ branding:

### `branding.color`

The background color of the badge. Can be one of: `white`, `yellow`, `blue`, `green`, `orange`, `red`, `purple`, or `gray-dark`.
The background color of the badge. Can be one of: `white`, `black`, `yellow`, `blue`, `green`, `orange`, `red`, `purple`, or `gray-dark`.

### `branding.icon`

Expand Down Expand Up @@ -725,6 +725,7 @@ Brand icons, and all the following icons, are omitted.
<li>sun</li>
<li>sunrise</li>
<li>sunset</li>
<li>table</li>
<li>tablet</li>
<li>tag</li>
<li>target</li>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ For example, Alibaba Cloud created [`aliyun/configure-aliyun-credentials-action`

If your cloud provider doesn't have an official action, or if you prefer to create custom scripts, you can manually request the JSON Web Token (JWT) from {% data variables.product.prodname_dotcom %}'s OIDC provider.

If you're not using an official action, then {% data variables.product.prodname_dotcom %} recommends that you use the Actions core toolkit. Alternatively, you can use the following environment variables to retrieve the token: `ACTIONS_RUNTIME_TOKEN`, `ACTIONS_ID_TOKEN_REQUEST_URL`.
If you're not using an official action, then {% data variables.product.prodname_dotcom %} recommends that you use the Actions core toolkit. Alternatively, you can use the following environment variables to retrieve the token: `ACTIONS_ID_TOKEN_REQUEST_TOKEN`, `ACTIONS_ID_TOKEN_REQUEST_URL`.

To update your workflows using this approach, you will need to make three changes to your YAML:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ The `google-github-actions/auth` action receives a JWT from the {% data variable

This example has a job called `Get_OIDC_ID_token` that uses actions to request a list of services from GCP.

* `<example-workload-identity-provider>`: Replace this with the path to your identity provider in GCP. For example, `projects/<example-project-id>/locations/global/workloadIdentityPools/<name-of-pool/providers/<name-of-provider>`
* `<example-workload-identity-provider>`: Replace this with the path to your identity provider in GCP. For example, `projects/<example-project-id>/locations/global/workloadIdentityPools/<name-of-pool>/providers/<name-of-provider>`
* `<example-service-account>`: Replace this with the name of your service account in GCP.
* `<project-id>`: Replace this with the ID of your GCP project.

Expand Down
2 changes: 0 additions & 2 deletions content/graphql/guides/managing-enterprise-accounts.md
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,6 @@ For more information about getting started with GraphQL, see "[AUTOTITLE](/graph

## GraphQL fields and types for the Enterprise Accounts API

Here's an overview of the new queries, mutations, and schema defined types available for use with the Enterprise Accounts API.

For more details about the new queries, mutations, and schema defined types available for use with the Enterprise Accounts API, see the sidebar with detailed GraphQL definitions from any [GraphQL reference page](/graphql).

You can access the reference docs from within the GraphQL explorer on GitHub. For more information, see "[AUTOTITLE](/graphql/guides/using-the-explorer#accessing-the-sidebar-docs)."
Expand Down
2 changes: 2 additions & 0 deletions data/reusables/actions/azure-vnet-procedures-prereqs.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ You will use a script to automate configuring your Azure resources.

* Save the following `.bicep` file. Name the file `actions-nsg-deployment.bicep`.

The `.bicep` file we provide contains the minimal set of rules to use {% data variables.product.company_short %}-hosted runners with Azure VNET. You may need to add rules for your specific use case.

{% note %}

**Note:** Alternatively, to allow {% data variables.product.prodname_actions %} to communicate with the runners, you can allow the same firewall domains that are required for communication between self-hosted runners and {% data variables.product.product_name %}. For more information, see "[AUTOTITLE](/actions/hosting-your-own-runners/managing-self-hosted-runners/about-self-hosted-runners#communication-between-self-hosted-runners-and-github-enterprise-cloud)." To determine the appropriate subnet IP address range, we recommend adding a 30% buffer to the maximum job concurrency you anticipate. For instance, if your network configuration's runners are set to a maximum job concurrency of 300, it's recommended to utilize a subnet IP address range that can accommodate at least 390 runners. This buffer helps ensure that your network can handle unexpected increases in VM needs to meet job concurrency without running out of IP addresses.
Expand Down

0 comments on commit bd77646

Please sign in to comment.