fix(runtime): respect max concurrent tasks in ExecutionEngine::execute_parallel()#1576
Open
SH20RAJ wants to merge 2 commits intomofa-org:mainfrom
Open
fix(runtime): respect max concurrent tasks in ExecutionEngine::execute_parallel()#1576SH20RAJ wants to merge 2 commits intomofa-org:mainfrom
SH20RAJ wants to merge 2 commits intomofa-org:mainfrom
Conversation
…gine::execute_parallel() (mofa-org#1505)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1505 - ExecutionEngine::execute_parallel() was spawning unbounded tokio tasks, completely ignoring the RuntimeConfig::max_concurrent_tasks setting, leading to potential resource exhaustion.
Problem
The execute_parallel() method spawned one tokio::spawn per input with zero concurrency limits. A caller passing 1,000 inputs would spawn 1,000 concurrent tasks simultaneously:
The RuntimeConfig::max_concurrent_tasks setting was effectively dead code—users could set it to 5 through AgentBuilder but the executor would ignore it.
Solution
Implement Semaphore-based back-pressure:
Impact
Testing
Tested with high-volume input (1000+ tasks) to verify:
GSOC 2026 Contribution
Critical bug fix for production stability. Addresses priority P1 issue #1505.
Cc: @Mustafa11300 @rahulkr182