feat(testing): add JUnitFormatter for deterministic XML test reports#1571
Open
murad-1999 wants to merge 1 commit intomofa-org:mainfrom
Open
feat(testing): add JUnitFormatter for deterministic XML test reports#1571murad-1999 wants to merge 1 commit intomofa-org:mainfrom
murad-1999 wants to merge 1 commit intomofa-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
This PR introduces the
JUnitFormatterto themofa-testingcrate, enabling the deterministic generation of Ant/Surefire compliant JUnit XML test reports.🔗 Related Issues
Closes #
Related to #
Issue #1567
🧠 Context
JUnitFormatter: Implements theReportFormattertrait to generate<testsuite>,<testcase>,<failure>, and<skipped/>XML tags natively.Cargo.toml.escape_xmlutility that safely encodes<,>,&,", and'. It also intercepts and strips invalid raw control characters and handles chaotic inputs (CDATA, emojis, null bytes) to prevent strict XML parsers from crashing.{:.3}).<failure message="...">attribute to prevent massive memory allocations and redundant XML bloat when handling massive stack traces.tests/src/report/mod.rsandtests/src/lib.rs🛠️ Changes
tests/src/lib.rs (Added public export)
tests/src/report/mod.rs (Added module export)
tests/src/report/format.rs (Core implementation, escape_xml logic, and unit tests)-->
🧪 How you Tested
Added comprehensive, strict string-literal snapshot tests covering:
test_all_passing: Validates a clean test run.test_mixed_status: Validates failures and skips mapping to<failure>and<skipped/>.test_case_with_error_payload: Validates basic XML character escaping.test_case_with_metadata: Validates structure when metadata is present.test_chaotic_escaping: Stress tests the escaping utility against null bytes, emojis, and deeply nested quotes.📸 Screenshots / Logs (if applicable)
If breaking:
🧹 Checklist
Code Quality
cargo fmtruncargo clippypasses without warningsTesting
cargo testpasses locally without any errorDocumentation
PR Hygiene
main🚀 Deployment Notes (if applicable)
🧩 Additional Notes for Reviewers