fix(foundation): add execution event parity for workflow lifecycle#1563
fix(foundation): add execution event parity for workflow lifecycle#1563Bhanudahiyaa wants to merge 2 commits intomofa-org:mainfrom
Conversation
|
This PR focuses on event contract parity at the workflow runtime boundary. ExecutionEvent already modeled retry/failure semantics, but executor emission didn’t consistently include those transitions. I kept the change intentionally narrow to mofa-foundation workflow event schema + executor emission points, and added regression tests to lock behavior for:
|
|
I reviewed the tests in this PR and they cover the main lifecycle paths well. I’d like to contribute by adding a few additional edge case tests:
These should help strengthen correctness guarantees for execution event sequencing. Please let me know if this direction works. |
|
@yabhimanyu2007-sys Those are good edge cases, especially around ordering and duplicate emissions. For this PR, I tried to keep the scope focused on establishing baseline lifecycle parity (retry/failure + pause/resume) and locking in the core transitions. I think the cases you mentioned would be great as a follow-up focused on event sequencing guarantees (e.g., ordering + dedup invariants), since that’s slightly orthogonal to just emitting the missing events. If you’re interested, feel free to open a separate PR building on top of this, happy to review 👍 |
Summary
Align workflow runtime event emission with ExecutionEvent schema for retry/failure and pause/resume lifecycle paths.
Motivation
Observability/debugging currently misses key execution transitions, causing a mismatch between declared event contracts and emitted runtime data.
Changes
Related Issues
#1562
Testing
Checklist