Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: App not works on custom local domain with shared dependencies #215

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix: App not works on custom local domain with shared dependencies #215

merged 2 commits into from
Dec 16, 2024

Conversation

nicotu01
Copy link
Contributor

@nicotu01 nicotu01 commented Dec 6, 2024

Fix #199

@nicotu01 nicotu01 changed the title App not works on custom local domain with shared dependencies fix: App not works on custom local domain with shared dependencies Dec 6, 2024
@nicotu01
Copy link
Contributor Author

nicotu01 commented Dec 6, 2024

Hi @gioboa
I think this will solve #199

However, I have a question. I don't understand this fetch, is it really useful ?

@gioboa
Copy link
Collaborator

gioboa commented Dec 6, 2024

However, I have a question. I don't understand this fetch, is it really useful ?

That fetch was there since the beginning of this new v1 release.
@zhangHongEn is it to start the process/check the endpoint?

@gioboa gioboa mentioned this pull request Dec 6, 2024
Closed
@zhangHongEn
Copy link
Contributor

You can remove fetch.

@nicotu01
Copy link
Contributor Author

I remove the fetch.

@nicotu01
Copy link
Contributor Author

nicotu01 commented Dec 16, 2024 •
edited
Loading

@gioboa can we merge this branch ?

gioboa
gioboa approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nicotu01 for your help 👏

@gioboa gioboa merged commit 246b8ef into module-federation:main Dec 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioboa gioboa gioboa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App not works on custom local domain with shared dependencies
3 participants
@nicotu01 @gioboa @zhangHongEn