Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Inject hostInit as entry if there are no html entry files #193

Merged
merged 2 commits into from
Nov 30, 2024

Conversation

RobinBomkamp
Copy link
Contributor

fix:
#189

@RobinBomkamp RobinBomkamp changed the title fix: Do not inject code into html files while ssr builds fix: Inject hostInit as entry if there are no html entry files Nov 28, 2024
@RobinBomkamp RobinBomkamp requested a review from gioboa November 29, 2024 07:00
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍 Thanks @RobinBomkamp
I'm really happy to merge your first PR in this project, kudos 🥳

@gioboa gioboa merged commit 4ae3c09 into module-federation:main Nov 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants