Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keep cache inside node_modules by default to avoid problems with prettier and eslint #139

Merged
merged 3 commits into from
Oct 4, 2024
Merged

fix: keep cache inside node_modules by default to avoid problems with prettier and eslint #139

merged 3 commits into from
Oct 4, 2024

Conversation

mshima
Copy link
Contributor

@mshima mshima commented Oct 4, 2024 •
edited
Loading

node_modules is commonly used as cache folder.
Usually it's eslint and prettier ignored.

Related to #137

@mshima mshima changed the title keep cache inside node_modules by default fix: keep cache inside node_modules by default Oct 4, 2024
@mshima mshima changed the title fix: keep cache inside node_modules by default fix: keep cache inside node_modules by default to avoid problems with prettier and eslint Oct 4, 2024
gioboa
gioboa approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mshima
Looks fine to me

@gioboa gioboa merged commit 23910d2 into module-federation:main Oct 4, 2024
4 checks passed
@mshima mshima deleted the patch-2 branch October 4, 2024 18:01
@gioboa
Copy link
Collaborator

gioboa commented Oct 4, 2024

With this change I have this error

[vite] Pre-transform error: Failed to resolve import "/[...]/vite/examples/vite-webpack-rspack/host/node_modules/.__mf__temp/host/localSharedImportMap"

Step to reproduce this issue:

pnpm build 
pnpm multi-example

@mshima
Copy link
Contributor Author

mshima commented Oct 4, 2024

With this change I have this error

[vite] Pre-transform error: Failed to resolve import "/[...]/vite/examples/vite-webpack-rspack/host/node_modules/.__mf__temp/host/localSharedImportMap"

Step to reproduce this issue:

pnpm build 
pnpm multi-example

Fixed in fixed in #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioboa gioboa gioboa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshima @gioboa