fix: normalize shared with trailing slash

module-federation · Dec 23, 2024 · 121dd52 · 121dd52
1 parent fed459d
commit 121dd52
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/plugins/pluginProxySharedModule_preBuild.ts b/src/plugins/pluginProxySharedModule_preBuild.ts
@@ -45,9 +45,7 @@ export function proxySharedModule(options: {
       config(config: UserConfig, { command }) {
         (config.resolve as any).alias.push(
           ...Object.keys(shared).map((key) => {
-            const pattern = key.endsWith('/')
-              ? `(^${key.replace(/\/$/, '')}(\/.+)?$)`
-              : `(^${key}$)`;
+            const pattern = key.endsWith('/') ? `(^${key.replace(/\/$/, '')}(\/)?$)` : `(^${key}$)`;
             return {
               // Intercept all shared requests and proxy them to loadShare
               find: new RegExp(pattern),

diff --git a/src/utils/normalizeModuleFederationOptions.ts b/src/utils/normalizeModuleFederationOptions.ts
@@ -195,13 +195,13 @@ function normalizeShared(
   const result: NormalizedShared = {};
   if (Array.isArray(shared)) {
     shared.forEach((key) => {
-      result[key] = normalizeShareItem(key, key);
+      result[cleanShareItem(key)] = normalizeShareItem(key, key);
     });
     return result;
   }
   if (typeof shared === 'object') {
     Object.keys(shared).forEach((key) => {
-      result[key] = normalizeShareItem(key, shared[key] as any);
+      result[cleanShareItem(key)] = normalizeShareItem(key, shared[key] as any);
     });
   }