fix(runtime): remove synthetic default import #4066
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're using module federation packages in a project with
skipLibCheck
set tofalse
, however the type check in that project is failing with recent versions as a result of a couple of issues. One of those issues is that a synthetic default import is used in theruntime
package due to the fact that the module being imported from doesn't actually specify a default export. This PR updates that import to use* as
syntax instead to make this more explicit and resolve the type error.This doesn't show up as as an error here due to the use of the
esModuleInterop
option in the base config, which defaultsallowSyntheticDefaultImports
totrue
as per the docs. To avoid this reoccurring in future, theallowSyntheticDefaultImports
property could be explicitly set tofalse
.The other issue we came across already has a fix raised in #4014 that is yet to be merged.
Related Issue
Similar to #4013.
Types of changes
Checklist