Skip to content

Conversation

jabrks
Copy link
Contributor

@jabrks jabrks commented Sep 14, 2025

Description

We're using module federation packages in a project with skipLibCheck set to false, however the type check in that project is failing with recent versions as a result of a couple of issues. One of those issues is that a synthetic default import is used in the runtime package due to the fact that the module being imported from doesn't actually specify a default export. This PR updates that import to use * as syntax instead to make this more explicit and resolve the type error.

This doesn't show up as as an error here due to the use of the esModuleInterop option in the base config, which defaults allowSyntheticDefaultImports to true as per the docs. To avoid this reoccurring in future, the allowSyntheticDefaultImports property could be explicitly set to false.

The other issue we came across already has a fix raised in #4014 that is yet to be merged.

Related Issue

Similar to #4013.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Sep 14, 2025

🦋 Changeset detected

Latest commit: e6abcb4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@module-federation/runtime Patch
@module-federation/devtools Patch
@module-federation/data-prefetch Patch
@module-federation/dts-plugin Patch
@module-federation/metro Patch
@module-federation/modern-js Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/retry-plugin Patch
@module-federation/runtime-tools Patch
@module-federation/webpack-bundler-runtime Patch
@module-federation/bridge-react Patch
@module-federation/bridge-vue3 Patch
@module-federation/enhanced Patch
@module-federation/metro-plugin-rnc-cli Patch
@module-federation/metro-plugin-rnef Patch
@module-federation/rsbuild-plugin Patch
@module-federation/rspack Patch
@module-federation/inject-external-runtime-core-plugin Patch
@module-federation/rspress-plugin Patch
@module-federation/storybook-addon Patch
@module-federation/modernjsapp Patch
remote5 Patch
website-new Patch
@module-federation/sdk Patch
@module-federation/managers Patch
@module-federation/manifest Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/bridge-shared Patch
@module-federation/bridge-react-webpack-plugin Patch
@module-federation/error-codes Patch
@module-federation/runtime-core Patch
create-module-federation Patch
@module-federation/cli Patch
@module-federation/esbuild Patch
@module-federation/utilities Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Sep 14, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit e6abcb4
🔍 Latest deploy log https://app.netlify.com/projects/module-federation-docs/deploys/68d267409510e400083f4f23
😎 Deploy Preview https://deploy-preview-4066--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@2heal1 2heal1 merged commit e89e972 into module-federation:main Sep 23, 2025
15 checks passed
@2heal1
Copy link
Member

2heal1 commented Sep 23, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants