fix: notice btns not matching colour of notice + gap issue #4823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMB11
added
frontend
tdgao
approved these changes
Nov 26, 2025
Contributor
tdgao
left a comment
tdgao
left a comment
There was a problem hiding this comment.
Just a small comment on hard coded text
| @click="() => (preview ? {} : emit('dismiss'))" | ||
| > | ||
| <XIcon /> | ||
| <XIcon /> Dismiss |
Contributor
There was a problem hiding this comment.
Should this text use formatMessage?
Member
Author
There was a problem hiding this comment.
Yes, but i'll do an i18n pass when the majority of the new servers panel refactor is done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally was going to investigate notices not showing when an error appears on the panel, but it seems this was already fixed - so instead I fixed the colour of the buttons on the notice + gap issue