feat: integrate Mem0 memory management into code_scratch #730

vinci-grape · 2025-09-19T03:19:37Z

Change Summary

Add complete Mem0AI memory implementation with Mem0Memory class and SharedMemoryManager
Remove legacy mem0.py stub and implement full memory functionality
Integrate shared memory manager into LLMAgent for session and procedural memory
Add memory persistence capabilities for conversation and procedural memory
Refine architecture, coding, and refinement workflows with memory-aware processing

Related issue number

Checklist

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Run pre-commit install and pre-commit run --all-files before git commit, and passed lint check.
Documentation reflects the changes where applicable

gemini-code-assist · 2025-09-19T03:19:55Z

Summary of Changes

Hello @vinci-grape, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly upgrades the project's memory management by integrating Mem0AI. It introduces a robust system for shared and persistent memory within the LLMAgent, enabling more sophisticated conversational and procedural context retention. The changes span core agent logic, memory utilities, and project configurations, ensuring that the new memory capabilities are seamlessly incorporated into the existing workflows.

Highlights

Mem0 Integration: Introduced a complete Mem0AI memory implementation, including a Mem0Memory class and a SharedMemoryManager for efficient memory handling across agents.
LLMAgent Memory Management: Integrated the shared memory manager into the LLMAgent to support session and procedural memory, replacing a legacy mem0.py stub.
Memory Persistence: Added capabilities for persisting both conversation and procedural memories, allowing agents to retain context across interactions.
Workflow Refinements: Updated architecture, coding, and refinement workflows to leverage the new memory-aware processing, including changes to prompts and callback logic.
Dependency Updates: Added chromadb and mem0ai to the project requirements to support the new memory features.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request successfully integrates Mem0 for memory management, introducing a SharedMemoryManager and the Mem0Memory implementation. The changes enable the agent to handle both conversational and procedural memory, which is a great enhancement. My review focuses on improving code quality and robustness. I've identified a few issues, including an unused import, leftover commented code, a brittle string manipulation that could lead to bugs, and a typo in a configuration file's prompt. Addressing these points will make the new memory feature more reliable and the codebase cleaner.

gemini-code-assist · 2025-09-19T03:21:13Z

ms_agent/agent/memory/mem0ai.py

+
+        if system_message and hasattr(system_message, 'content'):
+            # Append memories to existing system message
+            system_message.content = system_message.content.split("\n\nUser Memories:\n")[0]


Using split("\n\nUser Memories:\n") to remove previous memories before injecting new ones is brittle. If the original system message contains this string for any other reason, it will be unintentionally truncated, which could lead to incorrect agent behavior. A more robust approach should be considered, such as storing the base system prompt separately and reconstructing it with the latest memories in each turn.

ms_agent/agent/memory/mem0ai.py

projects/code_scratch/architecture.yaml

wangxingjun778 · 2025-09-19T06:12:22Z

ms_agent/agent/llm_agent.py

                    f'which supports: {list(memory_mapping.keys())}')
-                self.memory_tools.append(memory_mapping[_memory.name](
-                    self.config))
+                if _memory.name == 'mem0':


Move the memory module to parent dir as an independent module.

Refer to this PR: #721

wangxingjun778 · 2025-09-19T06:13:55Z

requirements/framework.txt

 json5
 markdown
 mcp
+mem0ai


Can be optional dependency ?

wangxingjun778 · 2025-09-19T06:15:44Z

ms_agent/agent/llm_agent.py

        """Load and initialize memory components from the config."""
        if hasattr(self.config, 'memory'):
            for _memory in (self.config.memory or []):
                assert _memory.name in memory_mapping, (


Lint:

pip install pre-commit pre-commit run --all-files (if needed)

tastelikefeet · 2025-09-21T03:00:27Z

projects/code_scratch/callbacks/eval_callback.py

    def check_runtime():
        try:
-            os.system('pkill -f node')
+            # os.system('pkill -f node')


Delete code, not comment code if they are not needed

feat: integrate Mem0 memory management into code_scratch

40b799d

vinci-grape had a problem deploying to testci September 19, 2025 03:19 — with GitHub Actions Failure

gemini-code-assist bot reviewed Sep 19, 2025

View reviewed changes

update code_scratch

2ba4695

vinci-grape had a problem deploying to testci September 19, 2025 04:59 — with GitHub Actions Failure

wangxingjun778 reviewed Sep 19, 2025

View reviewed changes

fix bug in parse_messages

8954735

vinci-grape had a problem deploying to testci September 19, 2025 11:19 — with GitHub Actions Failure

tastelikefeet reviewed Sep 21, 2025

View reviewed changes

vinci-grape and others added 4 commits September 21, 2025 20:42

fix bug in llm_agent

7dfe801

update claude-4

48f11b4

fix conflicts and merge master

f5def4f

fix lint

2050513

wangxingjun778 had a problem deploying to testci September 22, 2025 02:33 — with GitHub Actions Failure

remove chromadb and mem0 from framework.txt as optional dependency

758fccb

wangxingjun778 had a problem deploying to testci September 22, 2025 02:49 — with GitHub Actions Failure

wangxingjun778 approved these changes Sep 22, 2025

View reviewed changes

wangxingjun778 merged commit b8a582f into main Sep 22, 2025
2 of 3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: integrate Mem0 memory management into code_scratch #730

feat: integrate Mem0 memory management into code_scratch #730

Uh oh!

vinci-grape commented Sep 19, 2025

Uh oh!

gemini-code-assist bot commented Sep 19, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Sep 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wangxingjun778 Sep 19, 2025

Uh oh!

wangxingjun778 Sep 19, 2025

Uh oh!

vinci-grape Sep 19, 2025

Uh oh!

wangxingjun778 Sep 19, 2025

Uh oh!

tastelikefeet Sep 21, 2025

Uh oh!

Uh oh!

Uh oh!

feat: integrate Mem0 memory management into code_scratch #730

feat: integrate Mem0 memory management into code_scratch #730

Uh oh!

Conversation

vinci-grape commented Sep 19, 2025

Change Summary

Related issue number

Checklist

Uh oh!

gemini-code-assist bot commented Sep 19, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wangxingjun778 Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

wangxingjun778 Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

vinci-grape Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

wangxingjun778 Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

tastelikefeet Sep 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!