-
Notifications
You must be signed in to change notification settings - Fork 73
Fix AppWorld setup via Python entrypoints #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix AppWorld setup via Python entrypoints #8
Conversation
Summary of ChangesHello @arjuntheprogrammer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request provides a workaround for an Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request implements a workaround for a failing appworld CLI command by calling the Python functions directly within the setup.sh script. The changes are functional and address the problem described. My review includes suggestions to improve the readability and maintainability of the embedded Python code within the shell script, which will make future modifications easier.
| # 5. 初始化 appworld | ||
| echo "📁 初始化 appworld..." | ||
| conda run -n appworld appworld install | ||
| conda run -n appworld python -c $'from appworld.install import install_package\ninstall_package()\n' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and to avoid the $'...' bashism, you could use a single-line Python command with a semicolon for this short script. This makes the command more straightforward.
| conda run -n appworld python -c $'from appworld.install import install_package\ninstall_package()\n' | |
| conda run -n appworld python -c 'from appworld.install import install_package; install_package()' |
| # 6. 下载数据 | ||
| echo "📦 下载数据(失败则使用备用下载)..." | ||
| if ! conda run -n appworld appworld download data; then | ||
| if ! conda run -n appworld python -c $'import os\nfrom appworld import update_root\nfrom appworld.download import download_data\nroot = os.environ.get("APPWORLD_ROOT") or "."\nupdate_root(root)\ndownload_data()\n'; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This inline Python script is quite long, which harms readability and makes it hard to maintain. For multi-line scripts inside a shell script, using a here-doc is a much more readable and standard practice.
I recommend refactoring this if statement to use one. You would replace the current line 44 with the following block:
if ! conda run -n appworld python <<'EOF'
import os
from appworld import update_root
from appworld.download import download_data
root = os.environ.get("APPWORLD_ROOT") or "."
update_root(root)
download_data()
EOF
thenThis makes the Python code much easier to read and edit.
6ef1569 to
2d7c14a
Compare
Summary
install_package) to avoid the CLI regressiondownload_data()directly so the setup script can finish reliablyFixes #6
Testing