Skip to content

Conversation

@arjuntheprogrammer
Copy link

@arjuntheprogrammer arjuntheprogrammer commented Nov 20, 2025

Summary

  • call the AppWorld installer via Python (install_package) to avoid the CLI regression
  • fetch AppWorld data by invoking download_data() directly so the setup script can finish reliably

Fixes #6

Testing

  • cd env_service/environments/appworld && bash setup.sh

@gemini-code-assist
Copy link

Summary of Changes

Hello @arjuntheprogrammer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a workaround for an appworld CLI installation failure by modifying the setup.sh script. It addresses issues with both the install and download data commands by directly executing their underlying Python functions within the Conda environment, bypassing potential problems with the appworld CLI, possibly related to a Typer CLI bug.

Highlights

  • Direct appworld installation: The appworld install command is now bypassed, and the install_package() function is directly invoked within the Conda environment using Python to ensure successful installation.
  • Direct data download: The appworld download data command is replaced with a direct Python call to download_data(), which also handles setting the APPWORLD_ROOT, to circumvent potential CLI issues during data retrieval.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a workaround for a failing appworld CLI command by calling the Python functions directly within the setup.sh script. The changes are functional and address the problem described. My review includes suggestions to improve the readability and maintainability of the embedded Python code within the shell script, which will make future modifications easier.

# 5. 初始化 appworld
echo "📁 初始化 appworld..."
conda run -n appworld appworld install
conda run -n appworld python -c $'from appworld.install import install_package\ninstall_package()\n'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and to avoid the $'...' bashism, you could use a single-line Python command with a semicolon for this short script. This makes the command more straightforward.

Suggested change
conda run -n appworld python -c $'from appworld.install import install_package\ninstall_package()\n'
conda run -n appworld python -c 'from appworld.install import install_package; install_package()'

# 6. 下载数据
echo "📦 下载数据(失败则使用备用下载)..."
if ! conda run -n appworld appworld download data; then
if ! conda run -n appworld python -c $'import os\nfrom appworld import update_root\nfrom appworld.download import download_data\nroot = os.environ.get("APPWORLD_ROOT") or "."\nupdate_root(root)\ndownload_data()\n'; then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This inline Python script is quite long, which harms readability and makes it hard to maintain. For multi-line scripts inside a shell script, using a here-doc is a much more readable and standard practice.

I recommend refactoring this if statement to use one. You would replace the current line 44 with the following block:

if ! conda run -n appworld python <<'EOF'
import os
from appworld import update_root
from appworld.download import download_data
root = os.environ.get("APPWORLD_ROOT") or "."
update_root(root)
download_data()
EOF
then

This makes the Python code much easier to read and edit.

@arjuntheprogrammer arjuntheprogrammer changed the title Work around appworld CLI install failure Improve env setup reliability and validate ReMe launch vars Nov 20, 2025
@arjuntheprogrammer arjuntheprogrammer changed the title Improve env setup reliability and validate ReMe launch vars Fix AppWorld setup via Python entrypoints Nov 20, 2025
@Kanaricc Kanaricc self-requested a review November 21, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setup.sh: appworld install fails with "Secondary flag" TypeError

1 participant