-
Notifications
You must be signed in to change notification settings - Fork 175
Examples/InductionMachines/IMC_DCBraking.mo #4691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
changes the comparisonSignals (old ones are bad - see discussion in modelica#4688)
Sorry @uschna I have to check in detail today's evening. |
Dear @AHaumer,
Hence, I must test it again. |
Thanks for looking into details, @uschna |
Dear @AHaumer, |
I would keep 4.1.1 for critical fixes, e.g. if we discover late that we introduced regressions in 4.1.0. |
Why not comparing the current phasor components, from which you are able to compute torque? |
enhances the mentioned example to avoid problems
changes the comparisonSignals (old ones are bad - see discussion in #4688)
@uschna pls. test
@GallLeo @MatthiasBSchaefer pls. prodice new reference result - thx!
@casella should we backport to 4.1.1? I suppose "no".