Skip to content

Conversation

HansOlsson
Copy link
Contributor

To me these print-messages starting with "Warning: " should be replaced by assertion-warnings.

@HansOlsson HansOlsson added L: Electrical.Polyphase Issue addresses Modelica.Electrical.Polyhase L: Electrical.QuasiStatic Issue addresses Modelica.Electrical.QuasiStatic labels Aug 12, 2025
@HansOlsson
Copy link
Contributor Author

Seems to be an issue with CI.

@beutlich beutlich changed the title WarningInsteadOfPrint Prefer warning instead of print message Aug 17, 2025
@HansOlsson
Copy link
Contributor Author

Looking more I realize that the det(L)>=epsilon test for singularity isn't good in general (for several reasons including performance, and scaling). I don't know if the matrices are small enough and normal inductance close enough to 1 that it works well enough.

@henrikt-ma
Copy link
Contributor

henrikt-ma commented Aug 18, 2025

Looking more I realize that the det(L)>=epsilon test for singularity isn't good in general (for several reasons including performance, and scaling). I don't know if the matrices are small enough and normal inductance close enough to 1 that it works well enough.

This is a good point, but outside the scope of this PR (which I believe is about getting rid of calls to Streams.print where a warning level assertion makes more sense). Opening a separate issue for a discussion of what do to instead would be a good start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Electrical.Polyphase Issue addresses Modelica.Electrical.Polyhase L: Electrical.QuasiStatic Issue addresses Modelica.Electrical.QuasiStatic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants