-
Notifications
You must be signed in to change notification settings - Fork 175
Add starting point for figures in Electrical Machines, PowerConvertes, QuasiStatic #4676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add starting point for figures in Electrical Machines, PowerConvertes, QuasiStatic #4676
Conversation
…s, QuasiStatic. These originate from figures created for Wolfram System Modeler, and are likely to need cleanup and improvement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just adding starting point for figures - thx @maltelenz - fine with me!
I investigated this PR using Dymola2025x. UnitsThis may be a Dymola issue, but the provided plots do not show units: ![]() (Dymola does not show time units -- but this is a very different issue.) Units and signalsThe PowerConverter examples show separated current and voltage waveforms. The units are in this case correctly display by Dymola2025x: ![]() Under some coditions (e. g. in Modelica.Electrical.PowerConverters.Examples.DCAC.PolyphaseTwoLevel.PolyphaseTwoLevel_RL) the units are displayed correctly: ![]() This may be caused by the (not correctly determined) units of the signal outputs of the current and voltage sensors. Units and axisThe provided examples
show
in one subplot. As the speed has a very different scale and behavior, it may make sense to show speed in a different subplot. Current and torque are much more physically connected, so it makes sense to show them in one diagram. For two figure with two different units I prefer plots with two different y axis. Similar issues of "unequal units with one axis" occur in:
Compare differentlyIn example
in three different subplots. Failed investigationsModels I could not test due to #4696 are:
|
These originate from figures created for Wolfram System Modeler, and are likely to need cleanup and improvement.
Our one existing figure in MSL is probably a good style to follow:
ModelicaStandardLibrary/Modelica/Blocks/package.mo
Lines 159 to 180 in 3f72865
Creating as Draft to indicate that library officer(s) probably want/should improve them before merging.