Skip to content

Conversation

maltelenz
Copy link
Contributor

These originate from figures created for Wolfram System Modeler, and are likely to need cleanup and improvement.

Our one existing figure in MSL is probably a good style to follow:

figures = {
Figure(
title = "Anti-windup compensation",
identifier = "anti-windup",
preferred = true,
plots = {
Plot(
title = "Reference tracking",
identifier = "tracking",
curves = {
Curve(y = integrator.y, legend = "Reference speed"),
Curve(y = inertia1.w, legend = "Actual speed")}),
Plot(
title = "Anti-windup limiter",
identifier = "limiter",
curves = {
Curve(y = PI.limiter.u, legend = "Input to the anti-windup limiter"),
Curve(y = PI.y, legend = "Controller output")})},
caption = "%(plot:tracking) Reference speed (%(variable:integrator.y)) and the actual speed (%(variable:inertia1.w)). The system initializes in steady state, since no transients are present. The inertia follows the reference speed quite good until the end of the constant speed phase. Then there is a deviation.
%(plot:limiter) Here the reason for the deviation can be seen: The output of the controller (%(variable:PI.y)) is in its limits. The anti-windup compensation works reasonably, since the input to the limiter (%(variable:PI.limiter.u)) is forced back to its limit after a transient phase.
")}));

Creating as Draft to indicate that library officer(s) probably want/should improve them before merging.

…s, QuasiStatic.

These originate from figures created for Wolfram System Modeler, and are likely to need cleanup and improvement.
@maltelenz maltelenz added the figures Related to figures/plots label Jul 16, 2025
@beutlich beutlich added example Issue only addresses example(s) L: Electrical.Machines Issue addresses Modelica.Electrical.Machines L: Electrical.PowerConverters Issue addresses Modelica.Electrical.PowerConverters L: Electrical.QuasiStatic Issue addresses Modelica.Electrical.QuasiStatic labels Jul 25, 2025
Copy link
Contributor

@AHaumer AHaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just adding starting point for figures - thx @maltelenz - fine with me!

@christiankral
Copy link
Contributor

christiankral commented Sep 22, 2025

I investigated this PR using Dymola2025x.

Units

This may be a Dymola issue, but the provided plots do not show units:

image

(Dymola does not show time units -- but this is a very different issue.)

Units and signals

The PowerConverter examples show separated current and voltage waveforms. The units are in this case correctly display by Dymola2025x:

image

Under some coditions (e. g. in Modelica.Electrical.PowerConverters.Examples.DCAC.PolyphaseTwoLevel.PolyphaseTwoLevel_RL) the units are displayed correctly:

image

This may be caused by the (not correctly determined) units of the signal outputs of the current and voltage sensors.

Units and axis

The provided examples

  • Modelica.Electrical.Machines.Examples.DCMachines.DCEE_Start
  • Modelica.Electrical.Machines.Examples.DCMachines.DCPM_Start
  • Modelica.Electrical.Machines.Examples.DCMachines.DCPM_Temperature
  • Modelica.Electrical.Machines.Examples.DCMachines.DCPM_withLosses
  • Modelica.Electrical.Machines.Examples.DCMachines.DCSE_SinglePhase
  • Modelica.Electrical.Machines.Examples.DCMachines.DCSE_Start
  • Modelica.Electrical.Machines.Examples.InductionMachines.IMC_DOL
  • Modelica.Electrical.Machines.Examples.InductionMachines.IMC_Inverter
  • Modelica.Electrical.Machines.Examples.InductionMachines.IMC_Transformer
  • Modelica.Electrical.Machines.Examples.InductionMachines.IMC_YD
  • Modelica.Electrical.Machines.Examples.InductionMachines.IMS_Start
  • Modelica.Electrical.Machines.Examples.SynchronousMachines.SMPM_Inverter
  • Modelica.Electrical.Machines.Examples.SynchronousMachines.SMR_Inverter

show

  • current (A)
  • torque (N.m)
  • speed (rev/min)

in one subplot. As the speed has a very different scale and behavior, it may make sense to show speed in a different subplot. Current and torque are much more physically connected, so it makes sense to show them in one diagram. For two figure with two different units I prefer plots with two different y axis.

Similar issues of "unequal units with one axis" occur in:

  • Modelica.Electrical.PowerConverters.Examples.DCDC.HBridge.HBridge_DC_Drive: voltage and speed
  • Modelica.Electrical.QuasiStatic.SinglePhase.Examples.ParallelResonance and Modelica.Electrical.QuasiStatic.SinglePhase.Examples.SeriesResonance: length and angle (which shall be in deg, so the DisplayUnit may have to be set properly, first)

Compare differently

In example Modelica.Electrical.Machines.Examples.DCMachines.DCPM_QuasiStatic it may make sense to directly compare

  • transient and quasi static current
  • transient and quasi static torque
  • transient and quasi static speed

in three different subplots.

Failed investigations

Models I could not test due to #4696 are:

  • Modelica.Electrical.Machines.Examples.InductionMachines.IMC_Conveyor
  • Modelica.Electrical.Machines.Examples.InductionMachines.IMC_withLosses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example Issue only addresses example(s) figures Related to figures/plots L: Electrical.Machines Issue addresses Modelica.Electrical.Machines L: Electrical.PowerConverters Issue addresses Modelica.Electrical.PowerConverters L: Electrical.QuasiStatic Issue addresses Modelica.Electrical.QuasiStatic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants