Skip to content

Remove binaries from repository#4347

Merged
maltelenz merged 2 commits intomodelica:masterfrom
maltelenz:remove-binaries
May 20, 2025
Merged

Remove binaries from repository#4347
maltelenz merged 2 commits intomodelica:masterfrom
maltelenz:remove-binaries

Conversation

@maltelenz
Copy link
Copy Markdown
Contributor

Binaries should be built separately, as discussed in #4250.

@maltelenz maltelenz added this to the MSL4.2.0 milestone Feb 28, 2024
Copy link
Copy Markdown
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Obviously don't merge to 4.1.0.

Comment thread .gitignore Outdated
@beutlich beutlich changed the title Remove binaries from repository. Remove binaries from repository Feb 28, 2024
@beutlich
Copy link
Copy Markdown
Member

Needs updating https://github.com/modelica/ModelicaStandardLibrary/wiki/Generating-a-new-MSL-release to also add the binaries to the release asset.

@beutlich beutlich added the L: Resources Issue addresses Modelica/Resources (excl. C-Sources) label Jun 11, 2024
@casella
Copy link
Copy Markdown
Contributor

casella commented Nov 11, 2024

@beutlich is the update of the https://github.com/modelica/ModelicaStandardLibrary/wiki/Generating-a-new-MSL-release guide the only missing thing to merge this PR?

@beutlich
Copy link
Copy Markdown
Member

beutlich commented Nov 11, 2024

@beutlich is the update of the https://github.com/modelica/ModelicaStandardLibrary/wiki/Generating-a-new-MSL-release guide the only missing thing to merge this PR?

Well, we could also add a deploy stage via CI (either manually or tag triggered).

@casella
Copy link
Copy Markdown
Contributor

casella commented Nov 11, 2024

Well, we could also add a deploy stage via CI (either manually or tag triggered).

Of course, maybe this deserves a separate ticket on its own?

@maltelenz maltelenz enabled auto-merge May 20, 2025 10:51
@casella casella self-requested a review May 20, 2025 10:51
maltelenz and others added 2 commits May 20, 2025 12:52
Binaries should be built separately, as discussed in modelica#4250.
Co-authored-by: Thomas Beutlich <[email protected]>
@maltelenz maltelenz merged commit 8adfbfc into modelica:master May 20, 2025
1 of 2 checks passed
@casella
Copy link
Copy Markdown
Contributor

casella commented May 20, 2025

The decision was taken long time ago, no reason to further delay pushing this on master

@beutlich
Copy link
Copy Markdown
Member

Of course, maybe this deserves a separate ticket on its own?

See #4645.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L: Resources Issue addresses Modelica/Resources (excl. C-Sources)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants