-
Notifications
You must be signed in to change notification settings - Fork 44
Apply modern table presentation to Versions #3737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
HansOlsson
merged 7 commits into
modelica:master
from
henrikt-ma:cleanup/version-annotations-table
Oct 17, 2025
Merged
Apply modern table presentation to Versions #3737
HansOlsson
merged 7 commits into
modelica:master
from
henrikt-ma:cleanup/version-annotations-table
Oct 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansOlsson
reviewed
Oct 1, 2025
HansOlsson
reviewed
Oct 1, 2025
HansOlsson
reviewed
Oct 1, 2025
HansOlsson
reviewed
Oct 1, 2025
HansOlsson
reviewed
Oct 1, 2025
HansOlsson
reviewed
Oct 1, 2025
HansOlsson
reviewed
Oct 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally good, but some minor comments.
Co-authored-by: Hans Olsson <[email protected]>
Co-authored-by: Hans Olsson <[email protected]>
@HansOlsson, in addition to addressing your comments, I also made the change in 6994d08. |
HansOlsson
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this, we can think more about how to express this kind of annotation in the record style.