Add full Modelica TestCase annotation also to Base Modelica #3542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansOlsson
reviewed
Sep 23, 2024
HansOlsson
previously requested changes
Sep 23, 2024
Sorry, I missed that. Of course it should be in the model |
Looks like a mistake to not place it side by side with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During test implementation, we have quickly arrived at a point where we need to build Base Modelica test models, so even if we are not going to be using the
TestCaseannotation ourselves, this indicates that the annotation is just as relevant for Base Modelica as it is for full Modelica.