MCP SDK: Add Prettier to Typescript SDK #953
Open
+31,779
−33,201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR's aim is to introduce Prettier to the Typescript SDK, in order to have consistent formatting.
Motivation and Context
Formatting is not automatic and there is no code formatting/styling tool to standardize that. That leads to PR code reviews having to manually identify any styling issues as opposed to that being automatic.
It is integrating prettier with the existing ESlint set up, and adding prettier --check . to the "lint" command in package.json
How Has This Been Tested?
Ran prettier --check . and prettier --write . (to apply the styling) on the full repository.
Breaking Changes
None, it's a devDependency.
Types of changes
Checklist
Additional context
As a further step, if Prettier gets agreed on and merged, a few improvements could be done on this initiative:
Maintainers please review the content of
.prettierrc.json
so any desired changes can be applied there andprettier --write .
can be ran again.