Skip to content

Bump pkce up to 5.0.0 to fix CJS dependency issue #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2025

Conversation

heyitsaamir
Copy link
Contributor

@heyitsaamir heyitsaamir commented Apr 2, 2025

This is to fix #217. This library wasn't working in CommonJS projects because pkce didn't export a commonjs version. In 5.0.0, they fixed this issue via crouchcd/pkce-challenge#33. In this PR, we are simply bumping the version to incorporate the fix.

The PKCE package was now exporting index.node.d.ts (for some reason), so I made a change in our tsconfig to resolve that correctly.

Motivation and Context

Without this, we weren't able to use this library in CJS projects. See issue mentioned above.

How Has This Been Tested?

Tested basic stuff locally, but not auth. Can someone who has auth stuff set up test that?

Breaking Changes

Don't think so. Unit tests pass but admittedly I have not tested the auth scenario.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@heyitsaamir
Copy link
Contributor Author

Apologies for the tag, but any chance we could prioritize this? CJS is broken without this.

@cliffhall / @allenzhou101

@wangshijun wangshijun mentioned this pull request Apr 5, 2025
9 tasks
Copy link
Contributor

@cliffhall cliffhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build and tests run locally. LGTM! 👍

@cliffhall cliffhall merged commit e2ab858 into modelcontextprotocol:main Apr 5, 2025
2 checks passed
@heyitsaamir
Copy link
Contributor Author

Thanks @cliffhall ! Hoping for a patch release soon! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@modelcontextprotocol/sdk fails in CommonJS projects due to incompatible ESM-only dependency (pkce-challenge)
2 participants