Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error handling to use ErrorData consistently #507

Merged

Conversation

alezkv
Copy link
Contributor

@alezkv alezkv commented Jan 10, 2025

Also:
Updated mcp dependency from 1.0.0 to 1.1.3

Description

fixes #471

Server Details

  • Server: fetch
  • Changes to: server

Motivation and Context

This aligns with MCP's error handling patterns and provides better structured error information.

How Has This Been Tested?

Tested with npx @modelcontextprotocol/inspector

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

Also:
Updated mcp dependency from 1.0.0 to 1.1.3

This aligns with MCP's error handling patterns and provides better
structured error information.
@alezkv
Copy link
Contributor Author

alezkv commented Jan 11, 2025

@dsp-ant Could you please take a look at this?

@dsp-ant dsp-ant force-pushed the main branch 27 times, most recently from e72628a to 8622936 Compare January 13, 2025 20:47
@dsp-ant dsp-ant force-pushed the main branch 25 times, most recently from c114833 to 4f3dc11 Compare January 14, 2025 03:05
@dsp-ant dsp-ant self-assigned this Jan 15, 2025
@dsp-ant
Copy link
Member

dsp-ant commented Jan 15, 2025

Thank you for improving the error handling consistency. The changes are focused and well-tested. This was generated by Claude.

@dsp-ant dsp-ant self-requested a review January 15, 2025 09:29
Copy link
Member

@dsp-ant dsp-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving the error handling consistency. The changes are focused and well-tested. This was generated by Claude.

@dsp-ant dsp-ant merged commit 3bf9d2c into modelcontextprotocol:main Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch is failing with argument mismatch
2 participants