Skip to content

Conversation

olaservo
Copy link
Member

Description

Adds support for automated tests for Sequential Thinking and updates SDK versions.

Server Details

  • Server: sequential thinking, everything, filesystem
  • Changes to: tests, sdk version

Motivation and Context

There were no automated tests for Sequential Thinking yet, and SDK versions were behind.

How Has This Been Tested?

Only automated tests so far.

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

@olaservo olaservo added the server-sequentialthinking Reference implementation for the Sequential Thinking MCP server - src/sequentialthinking label Oct 13, 2025
"@types/jest": "^29.5.14",
"@types/node": "^22",
"@types/yargs": "^17.0.32",
"jest": "^29.7.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think elsewhere we're migrating jest -> vitest. I think vitest works a lot better with TypeScript and is largely a drop-in replacement - possibly we should use that here instead?

(I've also used it in a bunch of other projects and really liked it)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like vitest vs jest as well. The PR in the Typescript repo shows how easy it is to migrate.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Since I just used the same test framework as other servers here and they also need to be converted, I'll just merge this PR as-is and convert all tests in one go separately: #2882

(This PR was a prerequisite to a couple other followup PRs already, so I'd prefer to have it merged sooner rather than later and unblock those, too.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the changes here: #2884

@olaservo olaservo merged commit a317804 into modelcontextprotocol:main Oct 19, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

server-sequentialthinking Reference implementation for the Sequential Thinking MCP server - src/sequentialthinking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants