Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example client to examples/clients folder #98

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

3choff
Copy link

@3choff 3choff commented Dec 11, 2024

Added a new example client to the examples/clients folder to demonstrate the usage of the SDK.

Motivation and Context

This change is needed to provide users with a practical example of how to implement the SDK in their applications. It helps new users understand the capabilities of the SDK and serves as a reference for best practices.

How Has This Been Tested?

I have tested the example client in a real application scenario, ensuring that it interacts correctly with the SDK and produces the expected results. Scenarios tested include:

  • Basic functionality of the chatbot.
  • Tested with multiple MCP servers using uvicorn and Node.js
  • Run type checking
  • Run linting

All tests passed successfully, confirming the code's quality and compliance with project standards.

Breaking Changes

No, this change does not introduce any breaking changes. Users will not need to update their existing code or configurations.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

3choff and others added 4 commits December 18, 2024 16:32
- Update type hints to use Python 3.10 syntax (dict, list, X | None)
- Replace requests with httpx for HTTP client consistency
- Improve async context management using AsyncExitStack
- Simplify server cleanup method
@3choff 3choff requested a review from dsp-ant December 23, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants