fix: HTTP timeout correctly passed to httpx #956
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
reviewed
Jun 13, 2025
| @@ -61,6 +61,7 @@ async def sse_client( | |||
| client, | |||
| "GET", | |||
| url, | |||
| timeout=httpx.Timeout(timeout, read=sse_read_timeout), | |||
There was a problem hiding this comment.
That is being passed on line 57... 👀
Kludex
reviewed
Jun 13, 2025
| @@ -106,7 +107,7 @@ async def sse_reader( | |||
| case _: | |||
| logger.warning(f"Unknown SSE event: {sse.event}") | |||
| except Exception as exc: | |||
| logger.error(f"Error in sse_reader: {exc}") | |||
| logger.error(f"Error in sse_reader: {exc.__class__.__name__}", exc_info=True) | |||
There was a problem hiding this comment.
Suggested change
| logger.error(f"Error in sse_reader: {exc.__class__.__name__}", exc_info=True) | |
| logger.exception("Error in sse_reader") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may take some time for a starting MCP server to response to GET request. Hence, users of MCP Python SDK must have ability to configure HTTP read timeout.
Motivation and Context
HTTP timeout passed to MCP client does not apply properly.
How Has This Been Tested?
Our MCP server may respond very slowly during initial warm up and cache filling.
Hence, if client successfully connects to it, it may timeout and leave the client in a inconsistent state leading to overall application failing to progress.
Breaking Changes
No
Types of changes
Checklist