add text encoding params to STDIO client #120
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds text encoding parameters to the STDIO Client. This allows the SDK user to configure how the text encoder will respond to errors and set the encoding used.
Motivation and Context
Fixes #110
This fixes an issue I was encountering in some of my programs when handling text from the internet.
How Has This Been Tested?
All of the included unit tests are passing with this (via
uv run pytest
)Styling was checked via
ruff check
I modified the example reproduction in #110 with an implementation of the new features (https://github.com/SecretiveShell/MCP-SDK-JSON-DECODE-ERROR/tree/test-fix)
Breaking Changes
None, all default values remain the same.
Types of changes
Checklist
Additional context
This was discussed in discord, and it was suggested that it would be beneficial to add extra test cases for this specific error. Currently this PR does not include this