fix: update ZIP EOCD comment_length when signing#204
Open
bryan-anthropic wants to merge 1 commit intomainfrom
Open
fix: update ZIP EOCD comment_length when signing#204bryan-anthropic wants to merge 1 commit intomainfrom
bryan-anthropic wants to merge 1 commit intomainfrom
Conversation
The signMcpbFile function appended a signature block to the ZIP file but did not update the EOCD comment_length field. Strict ZIP parsers (like Claude Desktop's) rejected these files because the declared comment length didn't account for the appended signature data. Now scans backwards for the EOCD magic bytes, reads the current comment_length, and adds the signature block length before concatenating. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #194.
comment_lengthfield, causing strict ZIP parsers (including Claude Desktop's) to reject signed files.findEocdOffset()helper to locate the EOCD record by scanning backwards for magic bytes0x06054b50.comment_lengthis now updated to include the signature block size.Test plan
comment_lengthis correctly updated after signingyarn build:codecompiles cleanlyyarn lintpasses🤖 Generated with Claude Code