Fix Reconnect handler #290
Merged
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In Sidebar.tsx - In Reconnect button handler, call onDisconnect before onConnect See: modelcontextprotocol#273 (comment)
cliffhall
requested review from
jspahrsummers,
ashwin-ant,
dsp-ant and
dend
and removed request for
jspahrsummers
|
Nice one @cliffhall ! |
cliffhall
requested review from
jerome3o-anthropic,
ant-joe,
a team and
tadasant
and removed request for
ashwin-ant,
jerome3o-anthropic,
ant-joe and
dsp-ant
tadasant
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #273
Motivation and Context
The Reconnect button was creating a new connection, but subsequent messages sent to the server went with the previous sessionId, and were therefore rejected. See #273
How Has This Been Tested?
Connect to the
server-everythingserver via SSEConnect to the
server-everythingserver via STDIOServer Everything SSE
Server Everything STDIO
Breaking Changes
Nope.
Types of changes
Checklist
Additional context
The troubleshooting that led to this fix.
See: #273 (comment)