fix: sweep table-cell escaping (CodeQL #74-#76) and document mcpdo's environment variables

[cliffhall]

Closes #2546
Closes #2640

These are the two remaining items from the v2.10.0 milestone merge, PR #2637 (#2623): CodeQL fails on #74–#76, and Copilot's second round flagged the environment-variable docs.

#2546: CodeQL #74–#76 (9c88e307, plus a Prettier reflow)

dependabot-alerts.mjs (twice) and sdk-watch.mjs escaped | in Markdown table cells but not \, so a value ending in a backslash re-exposed the pipe. A new shared helper, scripts/lib/markdown-cell.mjs escapeTableCell, escapes backslashes first, then pipes, and both scripts import it, so the three copies are gone. Its sibling test covers a trailing backslash and asserts that every pipe in the output sits behind an odd run of backslashes. The tests for the helper and both scripts pass, 155/155.

#2640: mcpdo in docs/environment-variables.md (7a2c154e)

• A new mcpdo connection daemon section documents MCP_INSPECTOR_DAEMON_DIR, MCP_INSPECTOR_DAEMON_TOKEN and MCP_ALLOW_DEFAULT_CONNECTION. Defaults and effects are taken from daemon/paths.ts, daemon/auth.ts and connection/dispatch.ts. These were documented only in the spec.
• mcpdo is named in the Read-by legend and in the 16 rows it reaches through core/. Each one was checked against the built mcpdo bundle: the variable name appears in it. The proxy rows are reached through EnvHttpProxyAgent in core/mcp/node/proxyFetch.ts, which core/mcp/node/transport.ts uses. Variables absent from the bundle (HOST, the ports, logging) are not marked.

Verification

npm run local:gate: every stage passes (scripts 996, format coverage 1448 files, DCO 2/2, smoke:mcpdo passed) except smoke:web:firefox, which cannot launch Playwright's Firefox on macOS 27 (#2625). local:storybook: 529 passed.

🤖 Generated with Claude Code

[Copilot]

🟡 Changes recommended

The documentation incorrectly promises mcpdo proxy support and implies support for unavailable command-line flags.

3 open findings

• Qualify callback URL flag override as CLI/TUI-only · New
• Qualify client config flag override as CLI/TUI-only · New
• mcpdo bypasses proxy-aware fetch · New

What changed in this PR

Addresses two release follow-ups: shared Markdown table-cell escaping for automation scripts and expanded mcpdo environment-variable documentation.

Changes:

• Centralizes backslash and pipe escaping across both dependency sweeps.
• Adds regression tests for escaping and non-string inputs.
• Documents mcpdo daemon variables and shared configuration readers.

File	Description
scripts/​sdk-watch.mjs	Uses the shared cell escaper.
scripts/​lib/​markdown-cell.test.mjs	Tests escaping edge cases and coercion.
scripts/​lib/​markdown-cell.mjs	Escapes backslashes before pipes.
scripts/​dependabot-alerts.mjs	Replaces duplicated escaping logic.
docs/​environment-variables.md	Adds mcpdo configuration documentation.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟢 Approval recommended

The escaping fix has focused regression coverage, and remaining feedback concerns minor documentation clarifications.

0 open findings

3 resolved since last review

• mcpdo bypasses proxy-aware fetch
• Qualify client config flag override as CLI/TUI-only
• Qualify callback URL flag override as CLI/TUI-only

Previously missed (2)

In code that hasn't changed since last review

Document mcpdo's non-interactive OAuth behavior

docs/​environment-variables.md:50

mcpdo is now listed, but the effect omits its distinct non-interactive behavior. When a connection needs OAuth, neither stdin nor stderr is a terminal, and --stored-auth-only is not set, mcpdo returns a pending connection and authorization URL rather than the CLI's auth-required error. Setting MCP_AUTO_OPEN_ENABLED=true instead keeps the blocking interactive flow (clients/mcpdo/src/connection/mcp.ts:687–724). Document this distinction for scripted callers.

Document daemon directory fallback to os.homedir()

docs/​environment-variables.md:70

The new daemon-directory default does not follow this blanket current-directory fallback. With no path override and neither HOME nor USERPROFILE set, getDaemonDir() uses os.homedir() (clients/mcpdo/src/daemon/paths.ts:23–30). Note that exception so users running under service managers look for the daemon socket and lock in the correct directory.

🧠 Review effort: Balanced

[cliffhall]

Round 2 raised two notes outside any thread, both on rows this PR touched. I verified each in source and fixed both in 337d5b1b:

• MCP_AUTO_OPEN_ENABLED (line 50): the row now describes mcpdo's non-TTY OAuth hand-off. With no TTY on stdin or stderr and no --stored-auth-only, connect exits 0 with a pending connection and an authUrl to relay; true keeps the blocking flow (connection/mcp.ts:687–724).
• USERPROFILE (line 70): the row now notes that the mcpdo daemon directory falls back to os.homedir(), not the working directory, when neither HOME nor USERPROFILE is set (daemon/paths.ts:23–30).

[Copilot]

🟢 Approval recommended

Only minor documentation and file-header nits remain; no blocking defects were identified.

0 open findings

🧠 Review effort: Balanced

[cliffhall]

Copilot review loop closed. Round 3 recommends approval with 0 open findings: no inline comments, and no suppressed block. Its headline mentions unspecified "minor nits", but none are itemized anywhere, so there is nothing actionable. Round 1's three findings and round 2's two notes are all fixed, and the mcpdo proxy gap is filed as #2642.